Allow option to abort validation after encountering N errors #408
+271
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 thanks for the fix! |
Collaborator
|
I really appreciate you making a PR for this! As I mentioned on the issue, rather than a boolean, I think it will be more generally useful as an integer for the maximum number of errors, where 0 is unlimited, 1 would do as this currently does, but you could specify some reasonable number like 10, which would cover 90% of normal validation problems with more useful feedback, but still prevent the DoS behavior. |
judah-w
changed the title
Author
|
Updated and added some unit tests, please let me know if there's anything that can be improved, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept of how to resolve this vulnerability: Performance: Linear response time degradation when processing large numbers of validation errors
I have: